| From 1f6252bbd524720411b847f646a2c4911a3bb0b3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 11 Dec 2023 10:24:28 -0500 |
| Subject: svcrdma: Remove queue-shortening warnings |
| |
| From: Chuck Lever <chuck.lever@oracle.com> |
| |
| [ Upstream commit b918bfcf370c92ea3b82fa9bb3d017702b5fa4cb ] |
| |
| These won't have much diagnostic value for site administrators. |
| Since they can't be disabled, they become noise. |
| |
| What's more, the subsequent rdma_create_qp() call adjusts the Send |
| Queue size (possibly downward) without warning, making the size |
| reported by these pr_warns inaccurate. |
| |
| Signed-off-by: Chuck Lever <chuck.lever@oracle.com> |
| Stable-dep-of: afcae7d7b8a2 ("RDMA/core: add rdma_rw_max_sge() helper for SQ sizing") |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/sunrpc/xprtrdma/svc_rdma_transport.c | 7 +------ |
| 1 file changed, 1 insertion(+), 6 deletions(-) |
| |
| diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c |
| index b00ea4dbe7d40..d6c9814644c6a 100644 |
| --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c |
| +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c |
| @@ -408,8 +408,6 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) |
| rq_depth = newxprt->sc_max_requests + newxprt->sc_max_bc_requests + |
| newxprt->sc_recv_batch; |
| if (rq_depth > dev->attrs.max_qp_wr) { |
| - pr_warn("svcrdma: reducing receive depth to %d\n", |
| - dev->attrs.max_qp_wr); |
| rq_depth = dev->attrs.max_qp_wr; |
| newxprt->sc_recv_batch = 1; |
| newxprt->sc_max_requests = rq_depth - 2; |
| @@ -419,11 +417,8 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) |
| ctxts = rdma_rw_mr_factor(dev, newxprt->sc_port_num, RPCSVC_MAXPAGES); |
| ctxts *= newxprt->sc_max_requests; |
| newxprt->sc_sq_depth = rq_depth + ctxts; |
| - if (newxprt->sc_sq_depth > dev->attrs.max_qp_wr) { |
| - pr_warn("svcrdma: reducing send depth to %d\n", |
| - dev->attrs.max_qp_wr); |
| + if (newxprt->sc_sq_depth > dev->attrs.max_qp_wr) |
| newxprt->sc_sq_depth = dev->attrs.max_qp_wr; |
| - } |
| atomic_set(&newxprt->sc_sq_avail, newxprt->sc_sq_depth); |
| |
| newxprt->sc_pd = ib_alloc_pd(dev, 0); |
| -- |
| 2.51.0 |
| |
