| From 60eb85c9e5de239f52be27ed562484002e7dd19d Mon Sep 17 00:00:00 2001 |
| From: Kangjie Lu <kjlu@umn.edu> |
| Date: Thu, 14 Mar 2019 01:30:59 -0500 |
| Subject: scsi: qla4xxx: fix a potential NULL pointer dereference |
| |
| [ Upstream commit fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6 ] |
| |
| In case iscsi_lookup_endpoint fails, the fix returns -EINVAL to avoid NULL |
| pointer dereference. |
| |
| Signed-off-by: Kangjie Lu <kjlu@umn.edu> |
| Acked-by: Manish Rangankar <mrangankar@marvell.com> |
| Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org> |
| --- |
| drivers/scsi/qla4xxx/ql4_os.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c |
| index a9fac1eb8306..28f6d5ef04e0 100644 |
| --- a/drivers/scsi/qla4xxx/ql4_os.c |
| +++ b/drivers/scsi/qla4xxx/ql4_os.c |
| @@ -3213,6 +3213,8 @@ static int qla4xxx_conn_bind(struct iscsi_cls_session *cls_session, |
| if (iscsi_conn_bind(cls_session, cls_conn, is_leading)) |
| return -EINVAL; |
| ep = iscsi_lookup_endpoint(transport_fd); |
| + if (!ep) |
| + return -EINVAL; |
| conn = cls_conn->dd_data; |
| qla_conn = conn->dd_data; |
| qla_conn->qla_ep = ep->dd_data; |
| -- |
| 2.19.1 |
| |
