| From c6f224dc20ad959175c2dfec70b5a61c6503a793 Mon Sep 17 00:00:00 2001 |
| From: Takashi Sakamoto <o-takashi@sakamocchi.jp> |
| Date: Sat, 21 Feb 2015 23:54:58 +0900 |
| Subject: ALSA: firewire-lib: remove reference counting |
| |
| From: Takashi Sakamoto <o-takashi@sakamocchi.jp> |
| |
| commit c6f224dc20ad959175c2dfec70b5a61c6503a793 upstream. |
| |
| AMDTP helper functions increment/decrement reference counter for an |
| instance of FireWire unit, while it's complicated for each driver to |
| process error state. |
| |
| In previous commit, each driver has the role of reference counting. This |
| commit removes this role from the helper function. |
| |
| Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/firewire/amdtp.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| --- a/sound/firewire/amdtp.c |
| +++ b/sound/firewire/amdtp.c |
| @@ -78,7 +78,7 @@ static void pcm_period_tasklet(unsigned |
| int amdtp_stream_init(struct amdtp_stream *s, struct fw_unit *unit, |
| enum amdtp_stream_direction dir, enum cip_flags flags) |
| { |
| - s->unit = fw_unit_get(unit); |
| + s->unit = unit; |
| s->direction = dir; |
| s->flags = flags; |
| s->context = ERR_PTR(-1); |
| @@ -102,7 +102,6 @@ void amdtp_stream_destroy(struct amdtp_s |
| { |
| WARN_ON(amdtp_stream_running(s)); |
| mutex_destroy(&s->mutex); |
| - fw_unit_put(s->unit); |
| } |
| EXPORT_SYMBOL(amdtp_stream_destroy); |
| |
