| From 3c92db0ab6524efd502a7bde35672b3f4c9ae500 Mon Sep 17 00:00:00 2001 |
| From: Young Xiao <YangX92@hotmail.com> |
| Date: Fri, 12 Apr 2019 15:45:06 +0800 |
| Subject: Drivers: misc: fix out-of-bounds access in function |
| param_set_kgdbts_var |
| |
| [ Upstream commit b281218ad4311a0342a40cb02fb17a363df08b48 ] |
| |
| There is an out-of-bounds access to "config[len - 1]" array when the |
| variable "len" is zero. |
| |
| See commit dada6a43b040 ("kgdboc: fix KASAN global-out-of-bounds bug |
| in param_set_kgdboc_var()") for details. |
| |
| Signed-off-by: Young Xiao <YangX92@hotmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/misc/kgdbts.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c |
| index fc7efedbc4be..94cbc5c98cae 100644 |
| --- a/drivers/misc/kgdbts.c |
| +++ b/drivers/misc/kgdbts.c |
| @@ -1134,7 +1134,7 @@ static void kgdbts_put_char(u8 chr) |
| |
| static int param_set_kgdbts_var(const char *kmessage, struct kernel_param *kp) |
| { |
| - int len = strlen(kmessage); |
| + size_t len = strlen(kmessage); |
| |
| if (len >= MAX_CONFIG_LEN) { |
| printk(KERN_ERR "kgdbts: config string too long\n"); |
| @@ -1154,7 +1154,7 @@ static int param_set_kgdbts_var(const char *kmessage, struct kernel_param *kp) |
| |
| strcpy(config, kmessage); |
| /* Chop out \n char as a result of echo */ |
| - if (config[len - 1] == '\n') |
| + if (len && config[len - 1] == '\n') |
| config[len - 1] = '\0'; |
| |
| /* Go and configure with the new params. */ |
| -- |
| 2.20.1 |
| |
