| From bc8a97faa68706dc6feed0bf5dc9bb495e007646 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 23 May 2022 18:42:54 +0400 |
| Subject: mmc: sdhci-of-esdhc: Fix refcount leak in esdhc_signal_voltage_switch |
| |
| From: Miaoqian Lin <linmq006@gmail.com> |
| |
| [ Upstream commit b5899a3e2f783a27b268e38d37f9b24c71bddf45 ] |
| |
| of_find_matching_node() returns a node pointer with refcount |
| incremented, we should use of_node_put() on it when not need anymore. |
| Add missing of_node_put() to avoid refcount leak. |
| of_node_put() checks null pointer. |
| |
| Fixes: ea35645a3c66 ("mmc: sdhci-of-esdhc: add support for signal voltage switch") |
| Signed-off-by: Miaoqian Lin <linmq006@gmail.com> |
| Link: https://lore.kernel.org/r/20220523144255.10310-1-linmq006@gmail.com |
| Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/mmc/host/sdhci-of-esdhc.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c |
| index d6cb0f9a3488..77ae23077f56 100644 |
| --- a/drivers/mmc/host/sdhci-of-esdhc.c |
| +++ b/drivers/mmc/host/sdhci-of-esdhc.c |
| @@ -704,6 +704,7 @@ static int esdhc_signal_voltage_switch(struct mmc_host *mmc, |
| scfg_node = of_find_matching_node(NULL, scfg_device_ids); |
| if (scfg_node) |
| scfg_base = of_iomap(scfg_node, 0); |
| + of_node_put(scfg_node); |
| if (scfg_base) { |
| sdhciovselcr = SDHCIOVSELCR_TGLEN | |
| SDHCIOVSELCR_VSELVAL; |
| -- |
| 2.35.1 |
| |
