| From bcdaa263a36678b6f27bd42b62f40d403cca9395 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 28 Nov 2018 16:06:44 -0800 |
| Subject: tcp: fix SNMP under-estimation on failed retransmission |
| |
| From: Yuchung Cheng <ycheng@google.com> |
| |
| [ Upstream commit ec641b39457e17774313b66697a8a1dc070257bd ] |
| |
| Previously the SNMP counter LINUX_MIB_TCPRETRANSFAIL is not counting |
| the TSO/GSO properly on failed retransmission. This patch fixes that. |
| |
| Signed-off-by: Yuchung Cheng <ycheng@google.com> |
| Signed-off-by: Eric Dumazet <edumazet@google.com> |
| Signed-off-by: Neal Cardwell <ncardwell@google.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/ipv4/tcp_output.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c |
| index 53f910bb55087..8971cc15d278b 100644 |
| --- a/net/ipv4/tcp_output.c |
| +++ b/net/ipv4/tcp_output.c |
| @@ -2919,7 +2919,7 @@ int __tcp_retransmit_skb(struct sock *sk, struct sk_buff *skb, int segs) |
| TCP_SKB_CB(skb)->sacked |= TCPCB_EVER_RETRANS; |
| trace_tcp_retransmit_skb(sk, skb); |
| } else if (err != -EBUSY) { |
| - NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPRETRANSFAIL); |
| + NET_ADD_STATS(sock_net(sk), LINUX_MIB_TCPRETRANSFAIL, segs); |
| } |
| return err; |
| } |
| -- |
| 2.20.1 |
| |
