| From f8ae0b4bb07772bd369210b4512fc814cb45403d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 7 Oct 2019 12:09:58 -0300 |
| Subject: media: ti-vpe: vpe: Make sure YUYV is set as default format |
| |
| From: Benoit Parrot <bparrot@ti.com> |
| |
| [ Upstream commit e20b248051ca0f90d84b4d9378e4780bc31f16c6 ] |
| |
| v4l2-compliance fails with this message: |
| |
| fail: v4l2-test-formats.cpp(672): \ |
| Video Capture Multiplanar: TRY_FMT(G_FMT) != G_FMT |
| fail: v4l2-test-formats.cpp(672): \ |
| Video Output Multiplanar: TRY_FMT(G_FMT) != G_FMT |
| ... |
| test VIDIOC_TRY_FMT: FAIL |
| |
| The default pixel format was setup as pointing to a specific offset in |
| the vpe_formats table assuming it was pointing to the V4L2_PIX_FMT_YUYV |
| entry. This became false after the addition on the NV21 format (see |
| above commid-id) |
| |
| So instead of hard-coding an offset which might change over time we need |
| to use a lookup helper instead so we know the default will always be what |
| we intended. |
| |
| Signed-off-by: Benoit Parrot <bparrot@ti.com> |
| Fixes: 40cc823f7005 ("media: ti-vpe: Add support for NV21 format") |
| Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/platform/ti-vpe/vpe.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c |
| index 15f0b0bb89c0..ca9095b80309 100644 |
| --- a/drivers/media/platform/ti-vpe/vpe.c |
| +++ b/drivers/media/platform/ti-vpe/vpe.c |
| @@ -2305,7 +2305,7 @@ static int vpe_open(struct file *file) |
| v4l2_ctrl_handler_setup(hdl); |
| |
| s_q_data = &ctx->q_data[Q_DATA_SRC]; |
| - s_q_data->fmt = &vpe_formats[2]; |
| + s_q_data->fmt = __find_format(V4L2_PIX_FMT_YUYV); |
| s_q_data->width = 1920; |
| s_q_data->height = 1080; |
| s_q_data->nplanes = 1; |
| -- |
| 2.20.1 |
| |