| From 10a24ff36c9d74998d396b864a00e5293e90b53d Mon Sep 17 00:00:00 2001 |
| From: Aditya Pakki <pakki001@umn.edu> |
| Date: Thu, 14 Mar 2019 15:31:40 -0500 |
| Subject: qlcnic: Avoid potential NULL pointer dereference |
| |
| [ Upstream commit 5bf7295fe34a5251b1d241b9736af4697b590670 ] |
| |
| netdev_alloc_skb can fail and return a NULL pointer which is |
| dereferenced without a check. The patch avoids such a scenario. |
| |
| Signed-off-by: Aditya Pakki <pakki001@umn.edu> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c |
| index 0a2318cad34d..63ebc491057b 100644 |
| --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c |
| +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c |
| @@ -1038,6 +1038,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode) |
| |
| for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) { |
| skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE); |
| + if (!skb) |
| + break; |
| qlcnic_create_loopback_buff(skb->data, adapter->mac_addr); |
| skb_put(skb, QLCNIC_ILB_PKT_SIZE); |
| adapter->ahw->diag_cnt = 0; |
| -- |
| 2.19.1 |
| |
