| From 37764da42d275b337e89b2f7486000ef8125fca1 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 30 Aug 2020 18:30:43 +0200 |
| Subject: media: tc358743: initialize variable |
| |
| From: Tom Rix <trix@redhat.com> |
| |
| [ Upstream commit 274cf92d5dff5c2fec1a518078542ffe70d07646 ] |
| |
| clang static analysis flags this error |
| |
| tc358743.c:1468:9: warning: Branch condition evaluates |
| to a garbage value |
| return handled ? IRQ_HANDLED : IRQ_NONE; |
| ^~~~~~~ |
| handled should be initialized to false. |
| |
| Fixes: d747b806abf4 ("[media] tc358743: add direct interrupt handling") |
| Signed-off-by: Tom Rix <trix@redhat.com> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/i2c/tc358743.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c |
| index bc630a7197761..1e95fdb61041b 100644 |
| --- a/drivers/media/i2c/tc358743.c |
| +++ b/drivers/media/i2c/tc358743.c |
| @@ -1325,7 +1325,7 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled) |
| static irqreturn_t tc358743_irq_handler(int irq, void *dev_id) |
| { |
| struct tc358743_state *state = dev_id; |
| - bool handled; |
| + bool handled = false; |
| |
| tc358743_isr(&state->sd, 0, &handled); |
| |
| -- |
| 2.25.1 |
| |
