| From e1718d97aa88ea44a6a8f50ff464253dd0dacf01 Mon Sep 17 00:00:00 2001 |
| From: Alex Deucher <alexander.deucher@amd.com> |
| Date: Wed, 24 Aug 2016 12:31:36 -0400 |
| Subject: drm/amdgpu: avoid a possible array overflow |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Alex Deucher <alexander.deucher@amd.com> |
| |
| commit e1718d97aa88ea44a6a8f50ff464253dd0dacf01 upstream. |
| |
| When looking up the connector type make sure the index |
| is valid. Avoids a later crash if we read past the end |
| of the array. |
| |
| Workaround for bug: |
| https://bugs.freedesktop.org/show_bug.cgi?id=97460 |
| |
| Reviewed-by: Christian Kรถnig <christian.koenig@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 6 ++++++ |
| 1 file changed, 6 insertions(+) |
| |
| --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c |
| +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c |
| @@ -321,6 +321,12 @@ bool amdgpu_atombios_get_connector_info_ |
| (le16_to_cpu(path->usConnObjectId) & |
| OBJECT_TYPE_MASK) >> OBJECT_TYPE_SHIFT; |
| |
| + if (con_obj_id >= ARRAY_SIZE(object_connector_convert)) { |
| + DRM_ERROR("invalid con_obj_id %d for device tag 0x%04x\n", |
| + con_obj_id, le16_to_cpu(path->usDeviceTag)); |
| + continue; |
| + } |
| + |
| connector_type = |
| object_connector_convert[con_obj_id]; |
| connector_object_id = con_obj_id; |