| From foo@baz Wed Dec 30 04:31:14 PM CET 2020 |
| From: Kailang Yang <kailang@realtek.com> |
| Date: Tue, 26 Nov 2019 17:04:23 +0800 |
| Subject: ALSA: hda/realtek - Dell headphone has noise on unmute for ALC236 |
| |
| From: Kailang Yang <kailang@realtek.com> |
| |
| commit e1e8c1fdce8b00fce08784d9d738c60ebf598ebc upstream |
| |
| headphone have noise even the volume is very small. |
| Let it fill up pcbeep hidden register to default value. |
| The issue was gone. |
| |
| Fixes: 4344aec84bd8 ("ALSA: hda/realtek - New codec support for ALC256") |
| Fixes: 736f20a70608 ("ALSA: hda/realtek - Add support for ALC236/ALC3204") |
| Signed-off-by: Kailang Yang <kailang@realtek.com> |
| Cc: <stable@vger.kernel.org> |
| Link: https://lore.kernel.org/r/9ae47f23a64d4e41a9c81e263cd8a250@realtek.com |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| [sudip: adjust context] |
| Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| sound/pci/hda/patch_realtek.c | 7 +++++-- |
| 1 file changed, 5 insertions(+), 2 deletions(-) |
| |
| --- a/sound/pci/hda/patch_realtek.c |
| +++ b/sound/pci/hda/patch_realtek.c |
| @@ -330,9 +330,7 @@ static void alc_fill_eapd_coef(struct hd |
| case 0x10ec0225: |
| case 0x10ec0233: |
| case 0x10ec0235: |
| - case 0x10ec0236: |
| case 0x10ec0255: |
| - case 0x10ec0256: |
| case 0x10ec0257: |
| case 0x10ec0282: |
| case 0x10ec0283: |
| @@ -343,6 +341,11 @@ static void alc_fill_eapd_coef(struct hd |
| case 0x10ec0299: |
| alc_update_coef_idx(codec, 0x10, 1<<9, 0); |
| break; |
| + case 0x10ec0236: |
| + case 0x10ec0256: |
| + alc_write_coef_idx(codec, 0x36, 0x5757); |
| + alc_update_coef_idx(codec, 0x10, 1<<9, 0); |
| + break; |
| case 0x10ec0285: |
| case 0x10ec0293: |
| alc_update_coef_idx(codec, 0xa, 1<<13, 0); |
