| From c9c1a14b06a19d4ed1156a5dca82964e2b0fdd06 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 14 Feb 2022 23:41:08 +0500 |
| Subject: selftests/x86: Add validity check and allow field splitting |
| |
| From: Muhammad Usama Anjum <usama.anjum@collabora.com> |
| |
| [ Upstream commit b06e15ebd5bfb670f93c7f11a29b8299c1178bc6 ] |
| |
| Add check to test if CC has a string. CC can have multiple sub-strings |
| like "ccache gcc". Erorr pops up if it is treated as single string and |
| double quotes are used around it. This can be fixed by removing the |
| quotes and not treating CC as a single string. |
| |
| Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection") |
| Reported-by: "kernelci.org bot" <bot@kernelci.org> |
| Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> |
| Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com> |
| Link: https://lkml.kernel.org/r/20220214184109.3739179-2-usama.anjum@collabora.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/testing/selftests/x86/check_cc.sh | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selftests/x86/check_cc.sh |
| index 172d3293fb7b..356689c56397 100755 |
| --- a/tools/testing/selftests/x86/check_cc.sh |
| +++ b/tools/testing/selftests/x86/check_cc.sh |
| @@ -7,7 +7,7 @@ CC="$1" |
| TESTPROG="$2" |
| shift 2 |
| |
| -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then |
| +if [ -n "$CC" ] && $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then |
| echo 1 |
| else |
| echo 0 |
| -- |
| 2.34.1 |
| |
