| From 145f746b85364655b5c0c5891b300d176d50674d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 22 Sep 2022 14:22:47 +0300 |
| Subject: drivers: serial: jsm: fix some leaks in probe |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 1d5859ef229e381f4db38dce8ed58e4bf862006b ] |
| |
| This error path needs to unwind instead of just returning directly. |
| |
| Fixes: 03a8482c17dd ("drivers: serial: jsm: Enable support for Digi Classic adapters") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Link: https://lore.kernel.org/r/YyxFh1+lOeZ9WfKO@kili |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/tty/serial/jsm/jsm_driver.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/jsm_driver.c |
| index cd30da0ef083..b5b61e598b53 100644 |
| --- a/drivers/tty/serial/jsm/jsm_driver.c |
| +++ b/drivers/tty/serial/jsm/jsm_driver.c |
| @@ -212,7 +212,8 @@ static int jsm_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent) |
| |
| break; |
| default: |
| - return -ENXIO; |
| + rc = -ENXIO; |
| + goto out_kfree_brd; |
| } |
| |
| rc = request_irq(brd->irq, brd->bd_ops->intr, IRQF_SHARED, "JSM", brd); |
| -- |
| 2.35.1 |
| |
