| From stable-owner@vger.kernel.org Fri Oct 13 23:44:46 2023 |
| From: Patrick Rohr <prohr@google.com> |
| Date: Fri, 13 Oct 2023 14:44:14 -0700 |
| Subject: net: release reference to inet6_dev pointer |
| To: stable@vger.kernel.org |
| Cc: "Greg KH" <gregkh@linuxfoundation.org>, "Sasha Levin" <sashal@kernel.org>, "Maciej Żenczykowski" <maze@google.com>, "Lorenzo Colitti" <lorenzo@google.com>, "Patrick Rohr" <prohr@google.com>, "David Ahern" <dsahern@kernel.org>, "Simon Horman" <horms@kernel.org>, "Leon Romanovsky" <leonro@nvidia.com>, "David S . Miller" <davem@davemloft.net> |
| Message-ID: <20231013214414.3482322-4-prohr@google.com> |
| |
| From: Patrick Rohr <prohr@google.com> |
| |
| commit 5cb249686e67dbef3ffe53887fa725eefc5a7144 upstream. |
| |
| addrconf_prefix_rcv returned early without releasing the inet6_dev |
| pointer when the PIO lifetime is less than accept_ra_min_lft. |
| |
| Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes") |
| Cc: Maciej Żenczykowski <maze@google.com> |
| Cc: Lorenzo Colitti <lorenzo@google.com> |
| Cc: David Ahern <dsahern@kernel.org> |
| Cc: Simon Horman <horms@kernel.org> |
| Reviewed-by: Simon Horman <horms@kernel.org> |
| Reviewed-by: Maciej Żenczykowski <maze@google.com> |
| Signed-off-by: Patrick Rohr <prohr@google.com> |
| Reviewed-by: Leon Romanovsky <leonro@nvidia.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/ipv6/addrconf.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/ipv6/addrconf.c |
| +++ b/net/ipv6/addrconf.c |
| @@ -2727,7 +2727,7 @@ void addrconf_prefix_rcv(struct net_devi |
| } |
| |
| if (valid_lft != 0 && valid_lft < in6_dev->cnf.accept_ra_min_lft) |
| - return; |
| + goto put; |
| |
| /* |
| * Two things going on here: |
