| From 1eedd167e92d0fc1e6b5a8d8c63f3fd2d41f20ce Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 25 Mar 2024 14:50:25 +0000 |
| Subject: media: dvbdev: Initialize sbuf |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Ricardo Ribalda <ribalda@chromium.org> |
| |
| [ Upstream commit 17d1316de0d7dc1bdc5d6e3ad4efd30a9bf1a381 ] |
| |
| Because the size passed to copy_from_user() cannot be known beforehand, |
| it needs to be checked during runtime with check_object_size. That makes |
| gcc believe that the content of sbuf can be used before init. |
| |
| Fix: |
| ./include/linux/thread_info.h:215:17: warning: ‘sbuf’ may be used uninitialized [-Wmaybe-uninitialized] |
| |
| Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/dvb-core/dvbdev.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c |
| index 23a0c209744dc..661588fc64f6a 100644 |
| --- a/drivers/media/dvb-core/dvbdev.c |
| +++ b/drivers/media/dvb-core/dvbdev.c |
| @@ -974,7 +974,7 @@ int dvb_usercopy(struct file *file, |
| int (*func)(struct file *file, |
| unsigned int cmd, void *arg)) |
| { |
| - char sbuf[128]; |
| + char sbuf[128] = {}; |
| void *mbuf = NULL; |
| void *parg = NULL; |
| int err = -EINVAL; |
| -- |
| 2.43.0 |
| |
