| From b002eeb638cdba75a661d928059e4770ce106557 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 12 Feb 2025 15:35:18 -0600 |
| Subject: soc: samsung: exynos-chipid: Add NULL pointer check in |
| exynos_chipid_probe() |
| |
| From: Chenyuan Yang <chenyuan0y@gmail.com> |
| |
| [ Upstream commit c8222ef6cf29dd7cad21643228f96535cc02b327 ] |
| |
| soc_dev_attr->revision could be NULL, thus, |
| a pointer check is added to prevent potential NULL pointer dereference. |
| This is similar to the fix in commit 3027e7b15b02 |
| ("ice: Fix some null pointer dereference issues in ice_ptp.c"). |
| |
| This issue is found by our static analysis tool. |
| |
| Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com> |
| Link: https://lore.kernel.org/r/20250212213518.69432-1-chenyuan0y@gmail.com |
| Fixes: 3253b7b7cd44 ("soc: samsung: Add exynos chipid driver support") |
| Cc: <stable@vger.kernel.org> |
| Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/soc/samsung/exynos-chipid.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c |
| index a2d163a1b4e11..fb9e80b63b917 100644 |
| --- a/drivers/soc/samsung/exynos-chipid.c |
| +++ b/drivers/soc/samsung/exynos-chipid.c |
| @@ -124,6 +124,8 @@ static int exynos_chipid_probe(struct platform_device *pdev) |
| |
| soc_dev_attr->revision = devm_kasprintf(&pdev->dev, GFP_KERNEL, |
| "%x", soc_info.revision); |
| + if (!soc_dev_attr->revision) |
| + return -ENOMEM; |
| soc_dev_attr->soc_id = product_id_to_soc_id(soc_info.product_id); |
| if (!soc_dev_attr->soc_id) { |
| pr_err("Unknown SoC\n"); |
| -- |
| 2.39.5 |
| |
