| From c451e599e0eeb4ca4472e7621504021d7d64961a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 22 Feb 2021 20:23:43 +0800 |
| Subject: IB/mlx5: Add missing error code |
| |
| From: YueHaibing <yuehaibing@huawei.com> |
| |
| [ Upstream commit 3a9b3d4536e0c25bd3906a28c1f584177e49dd0f ] |
| |
| Set err to -ENOMEM if kzalloc fails instead of 0. |
| |
| Fixes: 759738537142 ("IB/mlx5: Enable subscription for device events over DEVX") |
| Link: https://lore.kernel.org/r/20210222122343.19720-1-yuehaibing@huawei.com |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| Acked-by: Leon Romanovsky <leonro@nvidia.com> |
| Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/hw/mlx5/devx.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c |
| index ff8e17d7f7ca..8161035eb774 100644 |
| --- a/drivers/infiniband/hw/mlx5/devx.c |
| +++ b/drivers/infiniband/hw/mlx5/devx.c |
| @@ -1970,8 +1970,10 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DEVX_SUBSCRIBE_EVENT)( |
| |
| num_alloc_xa_entries++; |
| event_sub = kzalloc(sizeof(*event_sub), GFP_KERNEL); |
| - if (!event_sub) |
| + if (!event_sub) { |
| + err = -ENOMEM; |
| goto err; |
| + } |
| |
| list_add_tail(&event_sub->event_list, &sub_list); |
| uverbs_uobject_get(&ev_file->uobj); |
| -- |
| 2.30.1 |
| |
