| From f908ea9cb069d4cddd2cefd2f6ea49d6403f649f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 16 Jun 2024 19:16:33 +0300 |
| Subject: RDMA/mlx4: Fix truncated output warning in mad.c |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Leon Romanovsky <leonro@nvidia.com> |
| |
| [ Upstream commit 0d2e6992fc956e3308cd5376c18567def4cb3967 ] |
| |
| Increase size of the name array to avoid truncated output warning. |
| |
| drivers/infiniband/hw/mlx4/mad.c: In function ‘mlx4_ib_alloc_demux_ctx’: |
| drivers/infiniband/hw/mlx4/mad.c:2197:47: error: ‘%d’ directive output |
| may be truncated writing between 1 and 11 bytes into a region of size 4 |
| [-Werror=format-truncation=] |
| 2197 | snprintf(name, sizeof(name), "mlx4_ibt%d", port); |
| | ^~ |
| drivers/infiniband/hw/mlx4/mad.c:2197:38: note: directive argument in |
| the range [-2147483645, 2147483647] |
| 2197 | snprintf(name, sizeof(name), "mlx4_ibt%d", port); |
| | ^~~~~~~~~~~~ |
| drivers/infiniband/hw/mlx4/mad.c:2197:9: note: ‘snprintf’ output between |
| 10 and 20 bytes into a destination of size 12 |
| 2197 | snprintf(name, sizeof(name), "mlx4_ibt%d", port); |
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| drivers/infiniband/hw/mlx4/mad.c:2205:48: error: ‘%d’ directive output |
| may be truncated writing between 1 and 11 bytes into a region of size 3 |
| [-Werror=format-truncation=] |
| 2205 | snprintf(name, sizeof(name), "mlx4_ibwi%d", port); |
| | ^~ |
| drivers/infiniband/hw/mlx4/mad.c:2205:38: note: directive argument in |
| the range [-2147483645, 2147483647] |
| 2205 | snprintf(name, sizeof(name), "mlx4_ibwi%d", port); |
| | ^~~~~~~~~~~~~ |
| drivers/infiniband/hw/mlx4/mad.c:2205:9: note: ‘snprintf’ output between |
| 11 and 21 bytes into a destination of size 12 |
| 2205 | snprintf(name, sizeof(name), "mlx4_ibwi%d", port); |
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| drivers/infiniband/hw/mlx4/mad.c:2213:48: error: ‘%d’ directive output |
| may be truncated writing between 1 and 11 bytes into a region of size 3 |
| [-Werror=format-truncation=] |
| 2213 | snprintf(name, sizeof(name), "mlx4_ibud%d", port); |
| | ^~ |
| drivers/infiniband/hw/mlx4/mad.c:2213:38: note: directive argument in |
| the range [-2147483645, 2147483647] |
| 2213 | snprintf(name, sizeof(name), "mlx4_ibud%d", port); |
| | ^~~~~~~~~~~~~ |
| drivers/infiniband/hw/mlx4/mad.c:2213:9: note: ‘snprintf’ output between |
| 11 and 21 bytes into a destination of size 12 |
| 2213 | snprintf(name, sizeof(name), "mlx4_ibud%d", port); |
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| cc1: all warnings being treated as errors |
| make[6]: *** [scripts/Makefile.build:244: drivers/infiniband/hw/mlx4/mad.o] Error 1 |
| |
| Fixes: fc06573dfaf8 ("IB/mlx4: Initialize SR-IOV IB support for slaves in master context") |
| Link: https://lore.kernel.org/r/f3798b3ce9a410257d7e1ec7c9e285f1352e256a.1718554569.git.leon@kernel.org |
| Signed-off-by: Leon Romanovsky <leonro@nvidia.com> |
| Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/hw/mlx4/mad.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c |
| index d13ecbdd43917..3d29d5baf503e 100644 |
| --- a/drivers/infiniband/hw/mlx4/mad.c |
| +++ b/drivers/infiniband/hw/mlx4/mad.c |
| @@ -2158,7 +2158,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev, |
| struct mlx4_ib_demux_ctx *ctx, |
| int port) |
| { |
| - char name[12]; |
| + char name[21]; |
| int ret = 0; |
| int i; |
| |
| -- |
| 2.43.0 |
| |