| From 9486a9234c64e09c6520b2c9e542288408bf07b2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 18 Jan 2023 14:20:35 +0800 |
| Subject: pinctrl: mediatek: Initialize variable pullen and pullup to zero |
| |
| From: Guodong Liu <Guodong.Liu@mediatek.com> |
| |
| [ Upstream commit a298c70a10c604a6b3df5a0aa56597b705ba0f6b ] |
| |
| Coverity spotted that pullen and pullup is not initialized to zero in |
| mtk_pctrl_show_one_pin. The uninitialized variable pullen is used in |
| assignment statement "rsel = pullen;" in mtk_pctrl_show_one_pin, and |
| Uninitialized variable pullup is used when calling scnprintf. Fix this |
| coverity by initializing pullen and pullup as zero. |
| |
| Fixes: 184d8e13f9b1 ("pinctrl: mediatek: Add support for pin configuration dump via debugfs.") |
| Signed-off-by: Guodong Liu <Guodong.Liu@mediatek.com> |
| Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> |
| Link: https://lore.kernel.org/r/20230118062036.26258-2-Guodong.Liu@mediatek.com |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c |
| index fc3487fccb948..d151612f4a18c 100644 |
| --- a/drivers/pinctrl/mediatek/pinctrl-paris.c |
| +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c |
| @@ -574,7 +574,7 @@ static int mtk_hw_get_value_wrap(struct mtk_pinctrl *hw, unsigned int gpio, int |
| ssize_t mtk_pctrl_show_one_pin(struct mtk_pinctrl *hw, |
| unsigned int gpio, char *buf, unsigned int buf_len) |
| { |
| - int pinmux, pullup, pullen, len = 0, r1 = -1, r0 = -1; |
| + int pinmux, pullup = 0, pullen = 0, len = 0, r1 = -1, r0 = -1; |
| const struct mtk_pin_desc *desc; |
| |
| if (gpio >= hw->soc->npins) |
| -- |
| 2.39.2 |
| |
