| From bed5b60bf67ccd8957b8c0558fead30c4a3f5d3f Mon Sep 17 00:00:00 2001 |
| From: Lv Ruyi <lv.ruyi@zte.com.cn> |
| Date: Tue, 29 Mar 2022 10:40:04 +0000 |
| Subject: proc: bootconfig: Add null pointer check |
| |
| From: Lv Ruyi <lv.ruyi@zte.com.cn> |
| |
| commit bed5b60bf67ccd8957b8c0558fead30c4a3f5d3f upstream. |
| |
| kzalloc is a memory allocation function which can return NULL when some |
| internal memory errors happen. It is safer to add null pointer check. |
| |
| Link: https://lkml.kernel.org/r/20220329104004.2376879-1-lv.ruyi@zte.com.cn |
| |
| Cc: stable@vger.kernel.org |
| Fixes: c1a3c36017d4 ("proc: bootconfig: Add /proc/bootconfig to show boot config list") |
| Acked-by: Masami Hiramatsu <mhiramat@kernel.org> |
| Reported-by: Zeal Robot <zealci@zte.com.cn> |
| Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> |
| Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| fs/proc/bootconfig.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/fs/proc/bootconfig.c |
| +++ b/fs/proc/bootconfig.c |
| @@ -32,6 +32,8 @@ static int __init copy_xbc_key_value_lis |
| int ret = 0; |
| |
| key = kzalloc(XBC_KEYLEN_MAX, GFP_KERNEL); |
| + if (!key) |
| + return -ENOMEM; |
| |
| xbc_for_each_key_value(leaf, val) { |
| ret = xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX); |
