| From 485ecd0ac33787e62539eeb25bd3d5fa0c691045 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 27 Jun 2022 15:05:53 +0300 |
| Subject: net/mlx5e: Fix capability check for updating vnic env counters |
| |
| From: Gal Pressman <gal@nvidia.com> |
| |
| [ Upstream commit 452133dd580811f184e76b1402983182ee425298 ] |
| |
| The existing capability check for vnic env counters only checks for |
| receive steering discards, although we need the counters update for the |
| exposed internal queue oob counter as well. This could result in the |
| latter counter not being updated correctly when the receive steering |
| discards counter is not supported. |
| Fix that by checking whether any counter is supported instead of only |
| the steering counter capability. |
| |
| Fixes: 0cfafd4b4ddf ("net/mlx5e: Add device out of buffer counter") |
| Signed-off-by: Gal Pressman <gal@nvidia.com> |
| Reviewed-by: Tariq Toukan <tariqt@nvidia.com> |
| Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c |
| index bdc870f9c2f3..4429c848d4c4 100644 |
| --- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c |
| +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c |
| @@ -688,7 +688,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_UPDATE_STATS(vnic_env) |
| u32 in[MLX5_ST_SZ_DW(query_vnic_env_in)] = {}; |
| struct mlx5_core_dev *mdev = priv->mdev; |
| |
| - if (!MLX5_CAP_GEN(priv->mdev, nic_receive_steering_discard)) |
| + if (!mlx5e_stats_grp_vnic_env_num_stats(priv)) |
| return; |
| |
| MLX5_SET(query_vnic_env_in, in, opcode, MLX5_CMD_OP_QUERY_VNIC_ENV); |
| -- |
| 2.35.1 |
| |
