| From d819f3d6494a6fb36e4a4ab9b1ab246ba001ba1e Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 28 Feb 2024 08:53:16 +0100 |
| Subject: Revert "ACPI: PM: Block ASUS B1400CEAE from suspend to idle by |
| default" |
| |
| From: Daniel Drake <drake@endlessos.org> |
| |
| [ Upstream commit cb98555fcd8eee98c30165537c7e394f3a66e809 ] |
| |
| This reverts commit d52848620de00cde4a3a5df908e231b8c8868250, which was |
| originally put in place to work around a s2idle failure on this platform |
| where the NVMe device was inaccessible upon resume. |
| |
| After extended testing, we found that the firmware's implementation of S3 |
| is buggy and intermittently fails to wake up the system. We need to revert |
| to s2idle mode. |
| |
| The NVMe issue has now been solved more precisely in the commit titled |
| "PCI: Disable D3cold on Asus B1400 PCI-NVMe bridge" |
| |
| Link: https://bugzilla.kernel.org/show_bug.cgi?id=215742 |
| Link: https://lore.kernel.org/r/20240228075316.7404-2-drake@endlessos.org |
| Signed-off-by: Daniel Drake <drake@endlessos.org> |
| Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> |
| Acked-by: Jian-Hong Pan <jhp@endlessos.org> |
| Acked-by: Rafael J. Wysocki <rafael@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/acpi/sleep.c | 12 ------------ |
| 1 file changed, 12 deletions(-) |
| |
| diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c |
| index b9d203569ac1d..5996293f422e3 100644 |
| --- a/drivers/acpi/sleep.c |
| +++ b/drivers/acpi/sleep.c |
| @@ -382,18 +382,6 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = { |
| DMI_MATCH(DMI_PRODUCT_NAME, "20GGA00L00"), |
| }, |
| }, |
| - /* |
| - * ASUS B1400CEAE hangs on resume from suspend (see |
| - * https://bugzilla.kernel.org/show_bug.cgi?id=215742). |
| - */ |
| - { |
| - .callback = init_default_s3, |
| - .ident = "ASUS B1400CEAE", |
| - .matches = { |
| - DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), |
| - DMI_MATCH(DMI_PRODUCT_NAME, "ASUS EXPERTBOOK B1400CEAE"), |
| - }, |
| - }, |
| {}, |
| }; |
| |
| -- |
| 2.43.0 |
| |