| From 0b2182caf7d221314147bb4eb770aa03bb25aaf5 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 27 Aug 2024 16:44:21 +0200 |
| Subject: net: hisilicon: hns_mdio: fix OF node leak in probe() |
| |
| From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> |
| |
| [ Upstream commit e62beddc45f487b9969821fad3a0913d9bc18a2f ] |
| |
| Driver is leaking OF node reference from |
| of_parse_phandle_with_fixed_args() in probe(). |
| |
| Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> |
| Reviewed-by: Simon Horman <horms@kernel.org> |
| Link: https://patch.msgid.link/20240827144421.52852-4-krzysztof.kozlowski@linaro.org |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/hisilicon/hns_mdio.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c |
| index 7df5d7d211d47..58af9b4ae2be8 100644 |
| --- a/drivers/net/ethernet/hisilicon/hns_mdio.c |
| +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c |
| @@ -498,6 +498,7 @@ static int hns_mdio_probe(struct platform_device *pdev) |
| MDIO_SC_RESET_ST; |
| } |
| } |
| + of_node_put(reg_args.np); |
| } else { |
| dev_warn(&pdev->dev, "find syscon ret = %#x\n", ret); |
| mdio_dev->subctrl_vbase = NULL; |
| -- |
| 2.43.0 |
| |
