| From 7ef093ff596f584af41323b96029ad85510ae4d4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 12 Jun 2020 19:04:18 +0800 |
| Subject: drm/amd/display: Fix ineffective setting of max bpc property |
| |
| From: Stylon Wang <stylon.wang@amd.com> |
| |
| [ Upstream commit fa7041d9d2fc7401cece43f305eb5b87b7017fc4 ] |
| |
| [Why] |
| Regression was introduced where setting max bpc property has no effect |
| on the atomic check and final commit. It has the same effect as max bpc |
| being stuck at 8. |
| |
| [How] |
| Correctly propagate max bpc with the new connector state. |
| |
| Signed-off-by: Stylon Wang <stylon.wang@amd.com> |
| Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com> |
| Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |
| index b7e161f2a47d4..69b1f61928eff 100644 |
| --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |
| +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |
| @@ -4808,7 +4808,8 @@ create_validate_stream_for_sink(struct amdgpu_dm_connector *aconnector, |
| struct drm_connector *connector = &aconnector->base; |
| struct amdgpu_device *adev = connector->dev->dev_private; |
| struct dc_stream_state *stream; |
| - int requested_bpc = connector->state ? connector->state->max_requested_bpc : 8; |
| + const struct drm_connector_state *drm_state = dm_state ? &dm_state->base : NULL; |
| + int requested_bpc = drm_state ? drm_state->max_requested_bpc : 8; |
| enum dc_status dc_result = DC_OK; |
| |
| do { |
| -- |
| 2.25.1 |
| |