| From foo@baz Sat Oct 31 09:05:46 AM CET 2020 |
| From: Thomas Bogendoerfer <tbogendoerfer@suse.de> |
| Date: Mon, 26 Oct 2020 11:42:21 +0100 |
| Subject: ibmveth: Fix use of ibmveth in a bridge. |
| |
| From: Thomas Bogendoerfer <tbogendoerfer@suse.de> |
| |
| [ Upstream commit 2ac8af0967aaa2b67cb382727e784900d2f4d0da ] |
| |
| The check for src mac address in ibmveth_is_packet_unsupported is wrong. |
| Commit 6f2275433a2f wanted to shut down messages for loopback packets, |
| but now suppresses bridged frames, which are accepted by the hypervisor |
| otherwise bridging won't work at all. |
| |
| Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") |
| Signed-off-by: Michal Suchanek <msuchanek@suse.de> |
| Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> |
| Link: https://lore.kernel.org/r/20201026104221.26570-1-msuchanek@suse.de |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/ibm/ibmveth.c | 6 ------ |
| 1 file changed, 6 deletions(-) |
| |
| --- a/drivers/net/ethernet/ibm/ibmveth.c |
| +++ b/drivers/net/ethernet/ibm/ibmveth.c |
| @@ -1031,12 +1031,6 @@ static int ibmveth_is_packet_unsupported |
| ret = -EOPNOTSUPP; |
| } |
| |
| - if (!ether_addr_equal(ether_header->h_source, netdev->dev_addr)) { |
| - netdev_dbg(netdev, "source packet MAC address does not match veth device's, dropping packet.\n"); |
| - netdev->stats.tx_dropped++; |
| - ret = -EOPNOTSUPP; |
| - } |
| - |
| return ret; |
| } |
| |
