| From a68c4f0ab3651dda97ffdfb7ad7963586a75947d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 18 Nov 2022 09:12:49 +0800 |
| Subject: macsec: Fix invalid error code set |
| |
| From: YueHaibing <yuehaibing@huawei.com> |
| |
| [ Upstream commit 7cef6b73fba96abef731a53501924fc3c4a0f947 ] |
| |
| 'ret' is defined twice in macsec_changelink(), when it is set in macsec_is_offloaded |
| case, it will be invalid before return. |
| |
| Fixes: 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure") |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| Reviewed-by: Saeed Mahameed <saeed@kernel.org> |
| Reviewed-by: Antoine Tenart <atenart@kernel.org> |
| Link: https://lore.kernel.org/r/20221118011249.48112-1-yuehaibing@huawei.com |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/macsec.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c |
| index d145ad189778..104fc564a766 100644 |
| --- a/drivers/net/macsec.c |
| +++ b/drivers/net/macsec.c |
| @@ -3855,7 +3855,6 @@ static int macsec_changelink(struct net_device *dev, struct nlattr *tb[], |
| if (macsec_is_offloaded(macsec)) { |
| const struct macsec_ops *ops; |
| struct macsec_context ctx; |
| - int ret; |
| |
| ops = macsec_get_ops(netdev_priv(dev), &ctx); |
| if (!ops) { |
| -- |
| 2.35.1 |
| |
