| From 137e5c163d799c20a1a8a3c8dbe8ef655b824cc2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 14 Nov 2022 16:56:54 +0800 |
| Subject: fbdev: vermilion: decrease reference count in error path |
| |
| From: Xiongfeng Wang <wangxiongfeng2@huawei.com> |
| |
| [ Upstream commit 001f2cdb952a9566c77fb4b5470cc361db5601bb ] |
| |
| pci_get_device() will increase the reference count for the returned |
| pci_dev. For the error path, we need to use pci_dev_put() to decrease |
| the reference count. |
| |
| Fixes: dbe7e429fedb ("vmlfb: framebuffer driver for Intel Vermilion Range") |
| Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> |
| Signed-off-by: Helge Deller <deller@gmx.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/video/fbdev/vermilion/vermilion.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/video/fbdev/vermilion/vermilion.c b/drivers/video/fbdev/vermilion/vermilion.c |
| index ff61605b8764..a543643ce014 100644 |
| --- a/drivers/video/fbdev/vermilion/vermilion.c |
| +++ b/drivers/video/fbdev/vermilion/vermilion.c |
| @@ -277,8 +277,10 @@ static int vmlfb_get_gpu(struct vml_par *par) |
| |
| mutex_unlock(&vml_mutex); |
| |
| - if (pci_enable_device(par->gpu) < 0) |
| + if (pci_enable_device(par->gpu) < 0) { |
| + pci_dev_put(par->gpu); |
| return -ENODEV; |
| + } |
| |
| return 0; |
| } |
| -- |
| 2.35.1 |
| |
