| From 67bf80f0c4e8fdcb2d63672501ecbba957a62030 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 14 Dec 2022 11:23:16 +0800 |
| Subject: power: supply: rk817: Fix unsigned comparison with less than zero |
| |
| From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> |
| |
| [ Upstream commit 3268a4d9b0b85a4382e93bdf7be5400a73db74c5 ] |
| |
| The tmp is defined as u32 type, which results in invalid processing of |
| tmp<0 in function rk817_read_or_set_full_charge_on_boot(). Therefore, |
| drop the comparison. |
| |
| drivers/power/supply/rk817_charger.c:828 rk817_read_or_set_full_charge_on_boot() warn: unsigned 'tmp' is never less than zero. |
| drivers/power/supply/rk817_charger.c:788 rk817_read_or_set_full_charge_on_boot() warn: unsigned 'tmp' is never less than zero. |
| |
| Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3444 |
| Reported-by: Abaci Robot <abaci@linux.alibaba.com> |
| Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> |
| Tested-by: Chris Morgan <macromorgan@hotmail.com> |
| Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/power/supply/rk817_charger.c | 4 ---- |
| 1 file changed, 4 deletions(-) |
| |
| diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c |
| index 4f9c1c4179165..36f807b5ec442 100644 |
| --- a/drivers/power/supply/rk817_charger.c |
| +++ b/drivers/power/supply/rk817_charger.c |
| @@ -785,8 +785,6 @@ rk817_read_or_set_full_charge_on_boot(struct rk817_charger *charger, |
| regmap_bulk_read(rk808->regmap, RK817_GAS_GAUGE_Q_PRES_H3, |
| bulk_reg, 4); |
| tmp = get_unaligned_be32(bulk_reg); |
| - if (tmp < 0) |
| - tmp = 0; |
| boot_charge_mah = ADC_TO_CHARGE_UAH(tmp, |
| charger->res_div) / 1000; |
| /* |
| @@ -825,8 +823,6 @@ rk817_read_or_set_full_charge_on_boot(struct rk817_charger *charger, |
| regmap_bulk_read(rk808->regmap, RK817_GAS_GAUGE_Q_PRES_H3, |
| bulk_reg, 4); |
| tmp = get_unaligned_be32(bulk_reg); |
| - if (tmp < 0) |
| - tmp = 0; |
| boot_charge_mah = ADC_TO_CHARGE_UAH(tmp, charger->res_div) / 1000; |
| regmap_bulk_read(rk808->regmap, RK817_GAS_GAUGE_OCV_VOL_H, |
| bulk_reg, 2); |
| -- |
| 2.39.2 |
| |
