| From bae2bc73a59c200db53b6c15fb26bb758e2c6108 Mon Sep 17 00:00:00 2001 |
| From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> |
| Date: Wed, 13 Mar 2024 09:21:21 +0000 |
| Subject: usb: dwc2: host: Fix remote wakeup from hibernation |
| |
| From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> |
| |
| commit bae2bc73a59c200db53b6c15fb26bb758e2c6108 upstream. |
| |
| Starting from core v4.30a changed order of programming |
| GPWRDN_PMUACTV to 0 in case of exit from hibernation on |
| remote wakeup signaling from device. |
| |
| Fixes: c5c403dc4336 ("usb: dwc2: Add host/device hibernation functions") |
| CC: stable@vger.kernel.org |
| Signed-off-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> |
| Link: https://lore.kernel.org/r/99385ec55ce73445b6fbd0f471c9bd40eb1c9b9e.1708939799.git.Minas.Harutyunyan@synopsys.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/usb/dwc2/core.h | 1 + |
| drivers/usb/dwc2/hcd.c | 17 +++++++++++++---- |
| 2 files changed, 14 insertions(+), 4 deletions(-) |
| |
| --- a/drivers/usb/dwc2/core.h |
| +++ b/drivers/usb/dwc2/core.h |
| @@ -1084,6 +1084,7 @@ struct dwc2_hsotg { |
| bool needs_byte_swap; |
| |
| /* DWC OTG HW Release versions */ |
| +#define DWC2_CORE_REV_4_30a 0x4f54430a |
| #define DWC2_CORE_REV_2_71a 0x4f54271a |
| #define DWC2_CORE_REV_2_72a 0x4f54272a |
| #define DWC2_CORE_REV_2_80a 0x4f54280a |
| --- a/drivers/usb/dwc2/hcd.c |
| +++ b/drivers/usb/dwc2/hcd.c |
| @@ -5610,10 +5610,12 @@ int dwc2_host_exit_hibernation(struct dw |
| dwc2_writel(hsotg, hr->hcfg, HCFG); |
| |
| /* De-assert Wakeup Logic */ |
| - gpwrdn = dwc2_readl(hsotg, GPWRDN); |
| - gpwrdn &= ~GPWRDN_PMUACTV; |
| - dwc2_writel(hsotg, gpwrdn, GPWRDN); |
| - udelay(10); |
| + if (!(rem_wakeup && hsotg->hw_params.snpsid >= DWC2_CORE_REV_4_30a)) { |
| + gpwrdn = dwc2_readl(hsotg, GPWRDN); |
| + gpwrdn &= ~GPWRDN_PMUACTV; |
| + dwc2_writel(hsotg, gpwrdn, GPWRDN); |
| + udelay(10); |
| + } |
| |
| hprt0 = hr->hprt0; |
| hprt0 |= HPRT0_PWR; |
| @@ -5638,6 +5640,13 @@ int dwc2_host_exit_hibernation(struct dw |
| hprt0 |= HPRT0_RES; |
| dwc2_writel(hsotg, hprt0, HPRT0); |
| |
| + /* De-assert Wakeup Logic */ |
| + if ((rem_wakeup && hsotg->hw_params.snpsid >= DWC2_CORE_REV_4_30a)) { |
| + gpwrdn = dwc2_readl(hsotg, GPWRDN); |
| + gpwrdn &= ~GPWRDN_PMUACTV; |
| + dwc2_writel(hsotg, gpwrdn, GPWRDN); |
| + udelay(10); |
| + } |
| /* Wait for Resume time and then program HPRT again */ |
| mdelay(100); |
| hprt0 &= ~HPRT0_RES; |