| From 1c486dcffca4193c8ab463158431e5a4410f33c1 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 12 Apr 2024 17:16:10 +0800 |
| Subject: RDMA/hns: Fix deadlock on SRQ async events. |
| |
| From: Chengchang Tang <tangchengchang@huawei.com> |
| |
| [ Upstream commit b46494b6f9c19f141114a57729e198698f40af37 ] |
| |
| xa_lock for SRQ table may be required in AEQ. Use xa_store_irq()/ |
| xa_erase_irq() to avoid deadlock. |
| |
| Fixes: 81fce6291d99 ("RDMA/hns: Add SRQ asynchronous event support") |
| Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> |
| Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com> |
| Link: https://lore.kernel.org/r/20240412091616.370789-5-huangjunxian6@hisilicon.com |
| Signed-off-by: Leon Romanovsky <leon@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/hw/hns/hns_roce_main.c | 1 + |
| drivers/infiniband/hw/hns/hns_roce_srq.c | 6 +++--- |
| 2 files changed, 4 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c |
| index da1b33d818d82..afe7523eca909 100644 |
| --- a/drivers/infiniband/hw/hns/hns_roce_main.c |
| +++ b/drivers/infiniband/hw/hns/hns_roce_main.c |
| @@ -37,6 +37,7 @@ |
| #include <rdma/ib_smi.h> |
| #include <rdma/ib_user_verbs.h> |
| #include <rdma/ib_cache.h> |
| +#include "hnae3.h" |
| #include "hns_roce_common.h" |
| #include "hns_roce_device.h" |
| #include "hns_roce_hem.h" |
| diff --git a/drivers/infiniband/hw/hns/hns_roce_srq.c b/drivers/infiniband/hw/hns/hns_roce_srq.c |
| index 8dae98f827eb2..6a4923c21cbc6 100644 |
| --- a/drivers/infiniband/hw/hns/hns_roce_srq.c |
| +++ b/drivers/infiniband/hw/hns/hns_roce_srq.c |
| @@ -122,7 +122,7 @@ static int alloc_srqc(struct hns_roce_dev *hr_dev, struct hns_roce_srq *srq) |
| return ret; |
| } |
| |
| - ret = xa_err(xa_store(&srq_table->xa, srq->srqn, srq, GFP_KERNEL)); |
| + ret = xa_err(xa_store_irq(&srq_table->xa, srq->srqn, srq, GFP_KERNEL)); |
| if (ret) { |
| ibdev_err(ibdev, "failed to store SRQC, ret = %d.\n", ret); |
| goto err_put; |
| @@ -135,7 +135,7 @@ static int alloc_srqc(struct hns_roce_dev *hr_dev, struct hns_roce_srq *srq) |
| return 0; |
| |
| err_xa: |
| - xa_erase(&srq_table->xa, srq->srqn); |
| + xa_erase_irq(&srq_table->xa, srq->srqn); |
| err_put: |
| hns_roce_table_put(hr_dev, &srq_table->table, srq->srqn); |
| |
| @@ -153,7 +153,7 @@ static void free_srqc(struct hns_roce_dev *hr_dev, struct hns_roce_srq *srq) |
| dev_err(hr_dev->dev, "DESTROY_SRQ failed (%d) for SRQN %06lx\n", |
| ret, srq->srqn); |
| |
| - xa_erase(&srq_table->xa, srq->srqn); |
| + xa_erase_irq(&srq_table->xa, srq->srqn); |
| |
| if (refcount_dec_and_test(&srq->refcount)) |
| complete(&srq->free); |
| -- |
| 2.43.0 |
| |