| From c6932ee24a0e1357f34253160e615f7f0800a18b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 5 Jul 2024 13:42:06 +0200 |
| Subject: net: page_pool: fix warning code |
| |
| From: Johannes Berg <johannes.berg@intel.com> |
| |
| [ Upstream commit 946b6c48cca48591fb495508c5dbfade767173d0 ] |
| |
| WARN_ON_ONCE("string") doesn't really do what appears to |
| be intended, so fix that. |
| |
| Signed-off-by: Johannes Berg <johannes.berg@intel.com> |
| Fixes: 90de47f020db ("page_pool: fragment API support for 32-bit arch with 64-bit DMA") |
| Link: https://patch.msgid.link/20240705134221.2f4de205caa1.I28496dc0f2ced580282d1fb892048017c4491e21@changeid |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/core/page_pool.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/net/core/page_pool.c b/net/core/page_pool.c |
| index f4444b4e39e63..3772eb63dcad1 100644 |
| --- a/net/core/page_pool.c |
| +++ b/net/core/page_pool.c |
| @@ -445,7 +445,7 @@ static bool page_pool_dma_map(struct page_pool *pool, struct page *page) |
| return true; |
| |
| unmap_failed: |
| - WARN_ON_ONCE("unexpected DMA address, please report to netdev@"); |
| + WARN_ONCE(1, "unexpected DMA address, please report to netdev@"); |
| dma_unmap_page_attrs(pool->p.dev, dma, |
| PAGE_SIZE << pool->p.order, pool->p.dma_dir, |
| DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING); |
| -- |
| 2.43.0 |
| |
