| From stable+bounces-121456-greg=kroah.com@vger.kernel.org Fri Mar 7 23:50:44 2025 |
| From: Miguel Ojeda <ojeda@kernel.org> |
| Date: Fri, 7 Mar 2025 23:49:08 +0100 |
| Subject: rust: workqueue: remove unneeded ``#[allow(clippy::new_ret_no_self)]` |
| To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>, stable@vger.kernel.org |
| Cc: Danilo Krummrich <dakr@kernel.org>, Alice Ryhl <aliceryhl@google.com>, Alyssa Ross <hi@alyssa.is>, NoisyCoil <noisycoil@disroot.org>, patches@lists.linux.dev, Miguel Ojeda <ojeda@kernel.org> |
| Message-ID: <20250307225008.779961-2-ojeda@kernel.org> |
| |
| From: Miguel Ojeda <ojeda@kernel.org> |
| |
| commit 024f9676a6d236132119832a90fb9a1a9115b41a upstream. |
| |
| Perform the same clean commit b2516f7af9d2 ("rust: kernel: remove |
| `#[allow(clippy::new_ret_no_self)]`") did for a case that appeared in |
| workqueue in parallel in commit 7324b88975c5 ("rust: workqueue: add |
| helper for defining work_struct fields"): |
| |
| Clippy triggered a false positive on its `new_ret_no_self` lint |
| when using the `pin_init!` macro. Since Rust 1.67.0, that does |
| not happen anymore, since Clippy learnt to not warn about |
| `-> impl Trait<Self>` [1][2]. |
| |
| The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`. |
| |
| Link: https://github.com/rust-lang/rust-clippy/issues/7344 [1] |
| Link: https://github.com/rust-lang/rust-clippy/pull/9733 [2] |
| |
| Reviewed-by: Alice Ryhl <aliceryhl@google.com> |
| Reviewed-by: Trevor Gross <tmgross@umich.edu> |
| Tested-by: Gary Guo <gary@garyguo.net> |
| Reviewed-by: Gary Guo <gary@garyguo.net> |
| Link: https://lore.kernel.org/r/20240904204347.168520-2-ojeda@kernel.org |
| Signed-off-by: Miguel Ojeda <ojeda@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| rust/kernel/workqueue.rs | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/rust/kernel/workqueue.rs |
| +++ b/rust/kernel/workqueue.rs |
| @@ -366,7 +366,6 @@ unsafe impl<T: ?Sized, const ID: u64> Sy |
| impl<T: ?Sized, const ID: u64> Work<T, ID> { |
| /// Creates a new instance of [`Work`]. |
| #[inline] |
| - #[allow(clippy::new_ret_no_self)] |
| pub fn new(name: &'static CStr, key: &'static LockClassKey) -> impl PinInit<Self> |
| where |
| T: WorkItem<ID>, |
