| From 663ba477c81551af01d6c152244701b38fa5bab5 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 20 Jan 2025 15:42:51 +0100 |
| Subject: usb: phy: generic: Use proper helper for property detection |
| |
| From: Alexander Stein <alexander.stein@ew.tq-group.com> |
| |
| [ Upstream commit 309005e448c1f3e4b81e4416406991b7c3339c1d ] |
| |
| Since commit c141ecc3cecd7 ("of: Warn when of_property_read_bool() is |
| used on non-boolean properties") a warning is raised if this function |
| is used for property detection. of_property_present() is the correct |
| helper for this. |
| |
| Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> |
| Link: https://lore.kernel.org/r/20250120144251.580981-1-alexander.stein@ew.tq-group.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/phy/phy-generic.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c |
| index e7d50e0a16123..aadf98f65c608 100644 |
| --- a/drivers/usb/phy/phy-generic.c |
| +++ b/drivers/usb/phy/phy-generic.c |
| @@ -212,7 +212,7 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop) |
| if (of_property_read_u32(node, "clock-frequency", &clk_rate)) |
| clk_rate = 0; |
| |
| - needs_clk = of_property_read_bool(node, "clocks"); |
| + needs_clk = of_property_present(node, "clocks"); |
| } |
| nop->gpiod_reset = devm_gpiod_get_optional(dev, "reset", |
| GPIOD_ASIS); |
| -- |
| 2.39.5 |
| |
