| From b9a61defd3b4cc5b777e72b82023e04c0801d846 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 9 Feb 2026 14:53:53 +0100 |
| Subject: selftests: mlxsw: tc_restrictions: Fix test failure with new iproute2 |
| |
| From: Ido Schimmel <idosch@nvidia.com> |
| |
| [ Upstream commit a2646773a005b59fd1dc7ff3ba15df84889ca5d2 ] |
| |
| As explained in [1], iproute2 started rejecting tc-police burst sizes |
| that result in an overflow. This can happen when the burst size is high |
| enough and the rate is low enough. |
| |
| A couple of test cases specify such configurations, resulting in |
| iproute2 errors and test failure. |
| |
| Fix by reducing the burst size so that the test will pass with both new |
| and old iproute2 versions. |
| |
| [1] https://lore.kernel.org/netdev/20250916215731.3431465-1-jay.vosburgh@canonical.com/ |
| |
| Fixes: cb12d1763267 ("selftests: mlxsw: tc_restrictions: Test tc-police restrictions") |
| Signed-off-by: Ido Schimmel <idosch@nvidia.com> |
| Signed-off-by: Petr Machata <petrm@nvidia.com> |
| Reviewed-by: Simon Horman <horms@kernel.org> |
| Link: https://patch.msgid.link/88b00c6e85188aa6a065dc240206119b328c46e1.1770643998.git.petrm@nvidia.com |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/testing/selftests/drivers/net/mlxsw/tc_restrictions.sh | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/tools/testing/selftests/drivers/net/mlxsw/tc_restrictions.sh b/tools/testing/selftests/drivers/net/mlxsw/tc_restrictions.sh |
| index 0441a18f098b1..aac8ef490feb8 100755 |
| --- a/tools/testing/selftests/drivers/net/mlxsw/tc_restrictions.sh |
| +++ b/tools/testing/selftests/drivers/net/mlxsw/tc_restrictions.sh |
| @@ -317,7 +317,7 @@ police_limits_test() |
| |
| tc filter add dev $swp1 ingress pref 1 proto ip handle 101 \ |
| flower skip_sw \ |
| - action police rate 0.5kbit burst 1m conform-exceed drop/ok |
| + action police rate 0.5kbit burst 2k conform-exceed drop/ok |
| check_fail $? "Incorrect success to add police action with too low rate" |
| |
| tc filter add dev $swp1 ingress pref 1 proto ip handle 101 \ |
| @@ -327,7 +327,7 @@ police_limits_test() |
| |
| tc filter add dev $swp1 ingress pref 1 proto ip handle 101 \ |
| flower skip_sw \ |
| - action police rate 1.5kbit burst 1m conform-exceed drop/ok |
| + action police rate 1.5kbit burst 2k conform-exceed drop/ok |
| check_err $? "Failed to add police action with low rate" |
| |
| tc filter del dev $swp1 ingress protocol ip pref 1 handle 101 flower |
| -- |
| 2.51.0 |
| |
