| From e3ac13ac5568cd35726fb805115d5da68b2939d6 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 11 Mar 2025 06:20:10 +0000 |
| Subject: ASoC: tegra: Use non-atomic timeout for ADX status register |
| |
| From: Ritu Chaudhary <rituc@nvidia.com> |
| |
| [ Upstream commit f1d742c35b659fb0122da0a8ff09ad9309cb29d8 ] |
| |
| ADX startup() callback uses atomic poll timeout on ADX status register. |
| |
| This is unnecessary because: |
| |
| - The startup() callback itself is non-atomic. |
| - The subsequent timeout call in the same function already uses a |
| non-atomic version. |
| |
| Using atomic version can hog CPU when it is not really needed, |
| so replace it with non-atomic version. |
| |
| Fixes: a99ab6f395a9e ("ASoC: tegra: Add Tegra210 based ADX driver") |
| Signed-off-by: Ritu Chaudhary <rituc@nvidia.com> |
| Signed-off-by: Sheetal <sheetal@nvidia.com> |
| Link: https://patch.msgid.link/20250311062010.33412-1-sheetal@nvidia.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/tegra/tegra210_adx.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| diff --git a/sound/soc/tegra/tegra210_adx.c b/sound/soc/tegra/tegra210_adx.c |
| index 0aa93b948378f..3c10e09976ad0 100644 |
| --- a/sound/soc/tegra/tegra210_adx.c |
| +++ b/sound/soc/tegra/tegra210_adx.c |
| @@ -1,5 +1,5 @@ |
| // SPDX-License-Identifier: GPL-2.0-only |
| -// SPDX-FileCopyrightText: Copyright (c) 2021-2024 NVIDIA CORPORATION & AFFILIATES. |
| +// SPDX-FileCopyrightText: Copyright (c) 2021-2025 NVIDIA CORPORATION & AFFILIATES. |
| // All rights reserved. |
| // |
| // tegra210_adx.c - Tegra210 ADX driver |
| @@ -57,8 +57,8 @@ static int tegra210_adx_startup(struct snd_pcm_substream *substream, |
| int err; |
| |
| /* Ensure if ADX status is disabled */ |
| - err = regmap_read_poll_timeout_atomic(adx->regmap, TEGRA210_ADX_STATUS, |
| - val, !(val & 0x1), 10, 10000); |
| + err = regmap_read_poll_timeout(adx->regmap, TEGRA210_ADX_STATUS, |
| + val, !(val & 0x1), 10, 10000); |
| if (err < 0) { |
| dev_err(dai->dev, "failed to stop ADX, err = %d\n", err); |
| return err; |
| -- |
| 2.39.5 |
| |
