| From ab3cc8694c023632ed5530c35d74e546b6bb2cf0 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 18 Dec 2024 19:01:08 -0300 |
| Subject: arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from |
| pcie1 |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Nícolas F. R. A. Prado <nfraprado@collabora.com> |
| |
| [ Upstream commit 3d7fdd8e38aafd4858935df2392762c1ab8fb40f ] |
| |
| The MAC reset for PCIe port 1 on MT8195 when asserted during suspend |
| causes the system to hang during resume with the following error (with |
| no_console_suspend enabled): |
| |
| mtk-pcie-gen3 112f8000.pcie: PCIe link down, current LTSSM state: detect.quiet (0x0) |
| mtk-pcie-gen3 112f8000.pcie: PM: dpm_run_callback(): genpd_resume_noirq+0x0/0x24 returns -110 |
| mtk-pcie-gen3 112f8000.pcie: PM: failed to resume noirq: error -110 |
| |
| This issue is specific to MT8195. On MT8192 with the PCIe reset, |
| MT8192_INFRA_RST4_PCIE_TOP_SWRST, added to the DT node, the issue is not |
| observed. |
| |
| Since without the reset, the PCIe controller and WiFi card connected to |
| it, work just as well, remove the reset to allow the system to suspend |
| and resume properly. |
| |
| Fixes: ecc0af6a3fe6 ("arm64: dts: mt8195: Add pcie and pcie phy nodes") |
| Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> |
| Link: https://lore.kernel.org/r/20241218-mt8195-pcie1-reset-suspend-fix-v1-1-1c021dda42a6@collabora.com |
| Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/arm64/boot/dts/mediatek/mt8195.dtsi | 3 --- |
| 1 file changed, 3 deletions(-) |
| |
| diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi |
| index ade685ed2190b..04e41b557d448 100644 |
| --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi |
| +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi |
| @@ -1611,9 +1611,6 @@ |
| phy-names = "pcie-phy"; |
| power-domains = <&spm MT8195_POWER_DOMAIN_PCIE_MAC_P1>; |
| |
| - resets = <&infracfg_ao MT8195_INFRA_RST2_PCIE_P1_SWRST>; |
| - reset-names = "mac"; |
| - |
| #interrupt-cells = <1>; |
| interrupt-map-mask = <0 0 0 7>; |
| interrupt-map = <0 0 0 1 &pcie_intc1 0>, |
| -- |
| 2.39.5 |
| |
