| From 07476506fe28c0399074cc0810fe8b52cfdefef5 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 22 Jul 2025 20:19:17 +0200 |
| Subject: kcsan: test: Initialize dummy variable |
| |
| From: Marco Elver <elver@google.com> |
| |
| [ Upstream commit 9872916ad1a1a5e7d089e05166c85dbd65e5b0e8 ] |
| |
| Newer compiler versions rightfully point out: |
| |
| kernel/kcsan/kcsan_test.c:591:41: error: variable 'dummy' is |
| uninitialized when passed as a const pointer argument here |
| [-Werror,-Wuninitialized-const-pointer] |
| 591 | KCSAN_EXPECT_READ_BARRIER(atomic_read(&dummy), false); |
| | ^~~~~ |
| 1 error generated. |
| |
| Although this particular test does not care about the value stored in |
| the dummy atomic variable, let's silence the warning. |
| |
| Link: https://lkml.kernel.org/r/CA+G9fYu8JY=k-r0hnBRSkQQrFJ1Bz+ShdXNwC1TNeMt0eXaxeA@mail.gmail.com |
| Fixes: 8bc32b348178 ("kcsan: test: Add test cases for memory barrier instrumentation") |
| Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> |
| Reviewed-by: Alexander Potapenko <glider@google.com> |
| Signed-off-by: Marco Elver <elver@google.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| kernel/kcsan/kcsan_test.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c |
| index 6ce73cceaf53..1305bc0e2479 100644 |
| --- a/kernel/kcsan/kcsan_test.c |
| +++ b/kernel/kcsan/kcsan_test.c |
| @@ -533,7 +533,7 @@ static void test_barrier_nothreads(struct kunit *test) |
| struct kcsan_scoped_access *reorder_access = NULL; |
| #endif |
| arch_spinlock_t arch_spinlock = __ARCH_SPIN_LOCK_UNLOCKED; |
| - atomic_t dummy; |
| + atomic_t dummy = ATOMIC_INIT(0); |
| |
| KCSAN_TEST_REQUIRES(test, reorder_access != NULL); |
| KCSAN_TEST_REQUIRES(test, IS_ENABLED(CONFIG_SMP)); |
| -- |
| 2.39.5 |
| |