| From c314a28cdabe45f050fe7bd403ddeaf4b9c960d1 Mon Sep 17 00:00:00 2001 |
| From: Dikshita Agarwal <quic_dikshita@quicinc.com> |
| Date: Fri, 9 May 2025 14:08:55 +0530 |
| Subject: media: iris: Fix missing function pointer initialization |
| |
| From: Dikshita Agarwal <quic_dikshita@quicinc.com> |
| |
| commit c314a28cdabe45f050fe7bd403ddeaf4b9c960d1 upstream. |
| |
| The function pointers responsible for setting firmware properties were |
| never initialized in the instance capability structure, causing it to |
| remain NULL. As a result, the firmware properties were not being set |
| correctly. |
| |
| Fix this by properly assigning the function pointers from the core |
| capability to the instance capability, ensuring that the properties are |
| correctly applied to the firmware. |
| |
| Cc: stable@vger.kernel.org |
| Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon") |
| Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com> |
| Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> |
| Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD |
| Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-HDK |
| Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD |
| Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK |
| Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com> |
| Tested-by: Vikash Garodia <quic_vgarodia@quicinc.com> # on sa8775p-ride |
| Signed-off-by: Bryan O'Donoghue <bod@kernel.org> |
| Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/media/platform/qcom/iris/iris_ctrls.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/media/platform/qcom/iris/iris_ctrls.c |
| +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c |
| @@ -163,6 +163,7 @@ void iris_session_init_caps(struct iris_ |
| core->inst_fw_caps[cap_id].value = caps[i].value; |
| core->inst_fw_caps[cap_id].flags = caps[i].flags; |
| core->inst_fw_caps[cap_id].hfi_id = caps[i].hfi_id; |
| + core->inst_fw_caps[cap_id].set = caps[i].set; |
| } |
| } |
| |
