| From 702397da5a1a221249320349de98c0eb384e654b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 2 May 2023 11:35:36 -0700 |
| Subject: ionic: catch failure from devlink_alloc |
| |
| From: Shannon Nelson <shannon.nelson@amd.com> |
| |
| [ Upstream commit 4a54903ff68ddb33b6463c94b4eb37fc584ef760 ] |
| |
| Add a check for NULL on the alloc return. If devlink_alloc() fails and |
| we try to use devlink_priv() on the NULL return, the kernel gets very |
| unhappy and panics. With this fix, the driver load will still fail, |
| but at least it won't panic the kernel. |
| |
| Fixes: df69ba43217d ("ionic: Add basic framework for IONIC Network device driver") |
| Signed-off-by: Shannon Nelson <shannon.nelson@amd.com> |
| Reviewed-by: Simon Horman <simon.horman@corigine.com> |
| Reviewed-by: Jiri Pirko <jiri@nvidia.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/pensando/ionic/ionic_devlink.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c |
| index e6ff757895abb..4ec66a6be0738 100644 |
| --- a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c |
| +++ b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c |
| @@ -61,6 +61,8 @@ struct ionic *ionic_devlink_alloc(struct device *dev) |
| struct devlink *dl; |
| |
| dl = devlink_alloc(&ionic_dl_ops, sizeof(struct ionic), dev); |
| + if (!dl) |
| + return NULL; |
| |
| return devlink_priv(dl); |
| } |
| -- |
| 2.39.2 |
| |
