| From e035ec94bb0d12f1379188b4683cbcc2bcdf081c Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 21 Jan 2026 18:24:35 +0300 |
| Subject: ASoC: Intel: sof_es8336: fix headphone GPIO logic inversion |
| |
| From: Tagir Garaev <tgaraev653@gmail.com> |
| |
| [ Upstream commit 213c4e51267fd825cd21a08a055450cac7e0b7fb ] |
| |
| The headphone GPIO should be set to the inverse of speaker_en. |
| When speakers are enabled, headphones should be disabled and vice versa. |
| |
| Currently both GPIOs are set to the same value (speaker_en), causing |
| audio to play through both speakers and headphones simultaneously |
| when headphones are plugged in. |
| |
| Tested on Huawei Matebook (BOD-WXX9) with ES8336 codec. |
| |
| Fixes: 6e1ff1459e00 ("ASoC: Intel: sof_es8336: support a separate gpio to control headphone") |
| Signed-off-by: Tagir Garaev <tgaraev653@gmail.com> |
| Link: https://patch.msgid.link/20260121152435.101698-1-tgaraev653@gmail.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/intel/boards/sof_es8336.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/sound/soc/intel/boards/sof_es8336.c b/sound/soc/intel/boards/sof_es8336.c |
| index 9904a9e33cccb..c9d9381c76796 100644 |
| --- a/sound/soc/intel/boards/sof_es8336.c |
| +++ b/sound/soc/intel/boards/sof_es8336.c |
| @@ -120,7 +120,7 @@ static void pcm_pop_work_events(struct work_struct *work) |
| gpiod_set_value_cansleep(priv->gpio_speakers, priv->speaker_en); |
| |
| if (quirk & SOF_ES8336_HEADPHONE_GPIO) |
| - gpiod_set_value_cansleep(priv->gpio_headphone, priv->speaker_en); |
| + gpiod_set_value_cansleep(priv->gpio_headphone, !priv->speaker_en); |
| |
| } |
| |
| -- |
| 2.51.0 |
| |
