| From 6a8f1d15ed13f356e5d07fc444e27ce91608c584 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 19 Sep 2023 10:12:50 +0300 |
| Subject: drm/tilcdc: Fix irq free on unload |
| |
| From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> |
| |
| [ Upstream commit 38360bf96d816e175bc602c4ee76953cd303b71d ] |
| |
| The driver only frees the reserved irq if priv->irq_enabled is set to |
| true. However, the driver mistakenly sets priv->irq_enabled to false, |
| instead of true, in tilcdc_irq_install(), and thus the driver never |
| frees the irq, causing issues on loading the driver a second time. |
| |
| Fixes: b6366814fa77 ("drm/tilcdc: Convert to Linux IRQ interfaces") |
| Cc: Thomas Zimmermann <tzimmermann@suse.de> |
| Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com> |
| Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20230919-lcdc-v1-1-ba60da7421e1@ideasonboard.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c |
| index 8ebd7134ee21..2f6eaac7f659 100644 |
| --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c |
| +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c |
| @@ -138,7 +138,7 @@ static int tilcdc_irq_install(struct drm_device *dev, unsigned int irq) |
| if (ret) |
| return ret; |
| |
| - priv->irq_enabled = false; |
| + priv->irq_enabled = true; |
| |
| return 0; |
| } |
| -- |
| 2.43.0 |
| |
