| From 45be0882c5f91e1b92e645001dd1a53b3bd58c97 Mon Sep 17 00:00:00 2001 |
| From: Steve French <stfrench@microsoft.com> |
| Date: Mon, 5 Feb 2024 14:43:17 -0600 |
| Subject: smb3: add missing null server pointer check |
| |
| From: Steve French <stfrench@microsoft.com> |
| |
| commit 45be0882c5f91e1b92e645001dd1a53b3bd58c97 upstream. |
| |
| Address static checker warning in cifs_ses_get_chan_index(): |
| warn: variable dereferenced before check 'server' |
| To be consistent, and reduce risk, we should add another check |
| for null server pointer. |
| |
| Fixes: 88675b22d34e ("cifs: do not search for channel if server is terminating") |
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> |
| Reviewed-by: Shyam Prasad N <sprasad@microsoft.com> |
| Signed-off-by: Steve French <stfrench@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| fs/smb/client/sess.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/smb/client/sess.c |
| +++ b/fs/smb/client/sess.c |
| @@ -76,7 +76,7 @@ cifs_ses_get_chan_index(struct cifs_ses |
| unsigned int i; |
| |
| /* if the channel is waiting for termination */ |
| - if (server->terminate) |
| + if (server && server->terminate) |
| return CIFS_INVAL_CHAN_INDEX; |
| |
| for (i = 0; i < ses->chan_count; i++) { |
