| From e0d4e8acb3789c5a8651061fbab62ca24a45c063 Mon Sep 17 00:00:00 2001 |
| From: Su Hui <suhui@nfschina.com> |
| Date: Sun, 8 Oct 2023 14:39:30 +0800 |
| Subject: f2fs: avoid format-overflow warning |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Su Hui <suhui@nfschina.com> |
| |
| commit e0d4e8acb3789c5a8651061fbab62ca24a45c063 upstream. |
| |
| With gcc and W=1 option, there's a warning like this: |
| |
| fs/f2fs/compress.c: In function ‘f2fs_init_page_array_cache’: |
| fs/f2fs/compress.c:1984:47: error: ‘%u’ directive writing between |
| 1 and 7 bytes into a region of size between 5 and 8 |
| [-Werror=format-overflow=] |
| 1984 | sprintf(slab_name, "f2fs_page_array_entry-%u:%u", MAJOR(dev), |
| MINOR(dev)); |
| | ^~ |
| |
| String "f2fs_page_array_entry-%u:%u" can up to 35. The first "%u" can up |
| to 4 and the second "%u" can up to 7, so total size is "24 + 4 + 7 = 35". |
| slab_name's size should be 35 rather than 32. |
| |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Su Hui <suhui@nfschina.com> |
| Reviewed-by: Chao Yu <chao@kernel.org> |
| Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| fs/f2fs/compress.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/f2fs/compress.c |
| +++ b/fs/f2fs/compress.c |
| @@ -1976,7 +1976,7 @@ void f2fs_destroy_compress_inode(struct |
| int f2fs_init_page_array_cache(struct f2fs_sb_info *sbi) |
| { |
| dev_t dev = sbi->sb->s_bdev->bd_dev; |
| - char slab_name[32]; |
| + char slab_name[35]; |
| |
| if (!f2fs_sb_has_compression(sbi)) |
| return 0; |