| From 7a0da8d93267128ce1cf053db814eaf26b38490f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 8 Mar 2024 16:46:07 +0100 |
| Subject: arm64: dts: rockchip: enable internal pull-up on Q7_USB_ID for RK3399 |
| Puma |
| |
| From: Quentin Schulz <quentin.schulz@theobroma-systems.com> |
| |
| [ Upstream commit e6b1168f37e3f86d9966276c5a3fff9eb0df3e5f ] |
| |
| The Q7_USB_ID has a diode used as a level-shifter, and is used as an |
| input pin. The SoC default for this pin is a pull-up, which is correct |
| but the pinconf in the introducing commit missed that, so let's fix this |
| oversight. |
| |
| Fixes: ed2c66a95c0c ("arm64: dts: rockchip: fix rk3399-puma-haikou USB OTG mode") |
| Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> |
| Link: https://lore.kernel.org/r/20240308-puma-diode-pu-v2-1-309f83da110a@theobroma-systems.com |
| Signed-off-by: Heiko Stuebner <heiko@sntech.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi |
| index 20e3f41efe97f..9b9d70bf7f0ca 100644 |
| --- a/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi |
| +++ b/arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi |
| @@ -443,7 +443,7 @@ |
| usb3 { |
| usb3_id: usb3-id { |
| rockchip,pins = |
| - <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_none>; |
| + <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_up>; |
| }; |
| }; |
| }; |
| -- |
| 2.43.0 |
| |
