| From eb8756cac789d9008a78dfa650204f2ac20aa174 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 31 Jan 2024 22:49:51 +0100 |
| Subject: selftests: mptcp: decrease BW in simult flows |
| |
| From: Matthieu Baerts (NGI0) <matttbe@kernel.org> |
| |
| [ Upstream commit 5e2f3c65af47e527ccac54060cf909e3306652ff ] |
| |
| When running the simult_flow selftest in slow environments -- e.g. QEmu |
| without KVM support --, the results can be unstable. This selftest |
| checks if the aggregated bandwidth is (almost) fully used as expected. |
| |
| To help improving the stability while still keeping the same validation |
| in place, the BW and the delay are reduced to lower the pressure on the |
| CPU. |
| |
| Fixes: 1a418cb8e888 ("mptcp: simult flow self-tests") |
| Fixes: 219d04992b68 ("mptcp: push pending frames when subflow has free space") |
| Cc: stable@vger.kernel.org |
| Suggested-by: Paolo Abeni <pabeni@redhat.com> |
| Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> |
| Link: https://lore.kernel.org/r/20240131-upstream-net-20240131-mptcp-ci-issues-v1-6-4c1c11e571ff@kernel.org |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/testing/selftests/net/mptcp/simult_flows.sh | 8 ++++---- |
| 1 file changed, 4 insertions(+), 4 deletions(-) |
| |
| diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh |
| index 9096bf5794888..25693b37f820d 100755 |
| --- a/tools/testing/selftests/net/mptcp/simult_flows.sh |
| +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh |
| @@ -302,12 +302,12 @@ done |
| |
| setup |
| run_test 10 10 0 0 "balanced bwidth" |
| -run_test 10 10 1 50 "balanced bwidth with unbalanced delay" |
| +run_test 10 10 1 25 "balanced bwidth with unbalanced delay" |
| |
| # we still need some additional infrastructure to pass the following test-cases |
| -run_test 30 10 0 0 "unbalanced bwidth" |
| -run_test 30 10 1 50 "unbalanced bwidth with unbalanced delay" |
| -run_test 30 10 50 1 "unbalanced bwidth with opposed, unbalanced delay" |
| +run_test 10 3 0 0 "unbalanced bwidth" |
| +run_test 10 3 1 25 "unbalanced bwidth with unbalanced delay" |
| +run_test 10 3 25 1 "unbalanced bwidth with opposed, unbalanced delay" |
| |
| mptcp_lib_result_print_all_tap |
| exit $ret |
| -- |
| 2.43.0 |
| |
