| From 5f8d93ffc961accb20fb99d4a439875b3282d3af Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 26 Mar 2024 23:38:03 +0100 |
| Subject: mlx5: avoid truncating error message |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| [ Upstream commit b324a960354b872431d25959ad384ab66a7116ec ] |
| |
| clang warns that one error message is too long for its destination buffer: |
| |
| drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c:1876:4: error: 'snprintf' will always be truncated; specified size is 80, but format string expands to at least 94 [-Werror,-Wformat-truncation-non-kprintf] |
| |
| Reword it to be a bit shorter so it always fits. |
| |
| Fixes: 70f0302b3f20 ("net/mlx5: Bridge, implement mdb offload") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> |
| Link: https://lore.kernel.org/r/20240326223825.4084412-5-arnd@kernel.org |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c |
| index 1b9bc32efd6fa..c5ea1d1d2b035 100644 |
| --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c |
| +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c |
| @@ -1874,7 +1874,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *dev, u16 vport_num, u16 esw_ |
| "Failed to lookup bridge port vlan metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n", |
| addr, vid, vport_num); |
| NL_SET_ERR_MSG_FMT_MOD(extack, |
| - "Failed to lookup bridge port vlan metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n", |
| + "Failed to lookup vlan metadata for MDB (MAC=%pM,vid=%u,vport=%u)\n", |
| addr, vid, vport_num); |
| return -EINVAL; |
| } |
| -- |
| 2.43.0 |
| |
