| From 22b19cf206f4fa7b5cd61e855aec544f589139f6 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 28 Mar 2024 13:28:56 -0700 |
| Subject: Input: ims-pcu - fix printf string overflow |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| [ Upstream commit bf32bceedd0453c70d9d022e2e29f98e446d7161 ] |
| |
| clang warns about a string overflow in this driver |
| |
| drivers/input/misc/ims-pcu.c:1802:2: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 12 [-Werror,-Wformat-truncation] |
| drivers/input/misc/ims-pcu.c:1814:2: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 12 [-Werror,-Wformat-truncation] |
| |
| Make the buffer a little longer to ensure it always fits. |
| |
| Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Link: https://lore.kernel.org/r/20240326223825.4084412-7-arnd@kernel.org |
| Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/input/misc/ims-pcu.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c |
| index 6e8cc28debd97..80d16c92a08b3 100644 |
| --- a/drivers/input/misc/ims-pcu.c |
| +++ b/drivers/input/misc/ims-pcu.c |
| @@ -42,8 +42,8 @@ struct ims_pcu_backlight { |
| #define IMS_PCU_PART_NUMBER_LEN 15 |
| #define IMS_PCU_SERIAL_NUMBER_LEN 8 |
| #define IMS_PCU_DOM_LEN 8 |
| -#define IMS_PCU_FW_VERSION_LEN (9 + 1) |
| -#define IMS_PCU_BL_VERSION_LEN (9 + 1) |
| +#define IMS_PCU_FW_VERSION_LEN 16 |
| +#define IMS_PCU_BL_VERSION_LEN 16 |
| #define IMS_PCU_BL_RESET_REASON_LEN (2 + 1) |
| |
| #define IMS_PCU_PCU_B_DEVICE_ID 5 |
| -- |
| 2.43.0 |
| |
