| From a903f0865a190f8778c73df1a810ea6e25e5d7cf Mon Sep 17 00:00:00 2001 |
| From: Li Zefan <lizefan@huawei.com> |
| Date: Tue, 13 Aug 2013 10:05:59 +0800 |
| Subject: cpuset: fix the return value of cpuset_write_u64() |
| |
| From: Li Zefan <lizefan@huawei.com> |
| |
| commit a903f0865a190f8778c73df1a810ea6e25e5d7cf upstream. |
| |
| Writing to this file always returns -ENODEV: |
| |
| # echo 1 > cpuset.memory_pressure_enabled |
| -bash: echo: write error: No such device |
| |
| Signed-off-by: Li Zefan <lizefan@huawei.com> |
| Signed-off-by: Tejun Heo <tj@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| kernel/cpuset.c | 6 ++++-- |
| 1 file changed, 4 insertions(+), 2 deletions(-) |
| |
| --- a/kernel/cpuset.c |
| +++ b/kernel/cpuset.c |
| @@ -1502,11 +1502,13 @@ static int cpuset_write_u64(struct cgrou |
| { |
| struct cpuset *cs = cgroup_cs(cgrp); |
| cpuset_filetype_t type = cft->private; |
| - int retval = -ENODEV; |
| + int retval = 0; |
| |
| mutex_lock(&cpuset_mutex); |
| - if (!is_cpuset_online(cs)) |
| + if (!is_cpuset_online(cs)) { |
| + retval = -ENODEV; |
| goto out_unlock; |
| + } |
| |
| switch (type) { |
| case FILE_CPU_EXCLUSIVE: |
