| From effc6cc8828257c32c37635e737f14fd6e19ecd7 Mon Sep 17 00:00:00 2001 |
| From: Roland Dreier <roland@purestorage.com> |
| Date: Mon, 13 Feb 2012 16:18:16 -0800 |
| Subject: target: Don't set WBUS16 or SYNC bits in INQUIRY response |
| |
| From: Roland Dreier <roland@purestorage.com> |
| |
| commit effc6cc8828257c32c37635e737f14fd6e19ecd7 upstream. |
| |
| SPC-4 says about the WBUS16 and SYNC bits: |
| |
| The meanings of these fields are specific to SPI-5 (see 6.4.3). |
| For SCSI transport protocols other than the SCSI Parallel |
| Interface, these fields are reserved. |
| |
| We don't have a SPI fabric module, so we should never set these bits. |
| (The comment was misleading, since it only mentioned Sync but the |
| actual code set WBUS16 too). |
| |
| Signed-off-by: Roland Dreier <roland@purestorage.com> |
| Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/target/target_core_cdb.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/target/target_core_cdb.c |
| +++ b/drivers/target/target_core_cdb.c |
| @@ -116,7 +116,7 @@ target_emulate_inquiry_std(struct se_cmd |
| goto out; |
| } |
| |
| - buf[7] = 0x32; /* Sync=1 and CmdQue=1 */ |
| + buf[7] = 0x2; /* CmdQue=1 */ |
| |
| /* |
| * Do not include vendor, product, reversion info in INQUIRY |
