| From 031ed4d565b31880a4136bb7366bc89f5b1dba7d Mon Sep 17 00:00:00 2001 |
| From: Nicholas Bellinger <nab@linux-iscsi.org> |
| Date: Fri, 9 Mar 2012 23:45:38 -0800 |
| Subject: tcm_fc: Fix fc_exch memory leak in ft_send_resp_status |
| |
| From: Nicholas Bellinger <nab@linux-iscsi.org> |
| |
| commit 031ed4d565b31880a4136bb7366bc89f5b1dba7d upstream. |
| |
| This patch fixes a bug in tcm_fc where fc_exch memory from fc_exch_mgr->ep_pool |
| is currently being leaked by ft_send_resp_status() usage. Following current |
| code in ft_queue_status() response path, using lport->tt.seq_send() needs to be |
| followed by a lport->tt.exch_done() in order to release fc_exch memory back into |
| libfc_em kmem_cache. |
| |
| ft_send_resp_status() code is currently used in pre submit se_cmd ft_send_work() |
| error exceptions, TM request setup exceptions, and main TM response callback |
| path in ft_queue_tm_resp(). This bugfix addresses the leak in these cases. |
| |
| Cc: Mark D Rustad <mark.d.rustad@intel.com> |
| Cc: Kiran Patil <kiran.patil@intel.com> |
| Cc: Robert Love <robert.w.love@intel.com> |
| Cc: Andy Grover <agrover@redhat.com> |
| Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/target/tcm_fc/tfc_cmd.c | 6 ++++-- |
| 1 file changed, 4 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/target/tcm_fc/tfc_cmd.c |
| +++ b/drivers/target/tcm_fc/tfc_cmd.c |
| @@ -329,10 +329,12 @@ static void ft_send_resp_status(struct f |
| |
| fc_fill_reply_hdr(fp, rx_fp, FC_RCTL_DD_CMD_STATUS, 0); |
| sp = fr_seq(fp); |
| - if (sp) |
| + if (sp) { |
| lport->tt.seq_send(lport, sp, fp); |
| - else |
| + lport->tt.exch_done(sp); |
| + } else { |
| lport->tt.frame_send(lport, fp); |
| + } |
| } |
| |
| /* |
